[PATCH] Added an option to avoid splitting certain kinds of comments into lines.

Alp Toker alp at nuanti.com
Thu Jan 2 02:21:22 PST 2014


Just saw this after Manuel replied.

Is it OK to reformat IWYU pragmas in other coding styles, say in the 
LLVM style?

If not, that's an indication this kind of setting should be separated 
from individual coding style descriptions as it appears equally 
applicable to WebKit, Chromium, LLVM and custom styles.

It seems prudent not to add a public config setting with a commitment of 
stability until that's addressed or it'll be hard to fix after the fact.

Alp.

On 02/01/2014 09:58, Manuel Klimek wrote:
>    lg
>
>
> ================
> Comment at: unittests/Format/FormatTest.cpp:1053
> @@ +1052,3 @@
> +      "// IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb",
> +      format("// IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb", Pragmas));
> +}
> ----------------
> Please add a short test for block comments.
>
>
> http://llvm-reviews.chandlerc.com/D2460
>
> BRANCH
>    svn
>
> ARCANIST PROJECT
>    clang
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-- 
http://www.nuanti.com
the browser experts




More information about the cfe-commits mailing list