[PATCH] Verify clang TargetInfo DataLayouts against LLVM

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Dec 31 10:34:32 PST 2013


On 29 December 2013 23:53, Alp Toker <alp at nuanti.com> wrote:
> Hi Rafael,
>
> This is all that's left to enable opportunistic checking at clang IRGen time
> where an LLVM TargetMachine is available.
>
>  include/clang/CodeGen/BackendUtil.h |    4 ++--
>  lib/CodeGen/BackendUtil.cpp         |   11 ++++++++---
>  lib/CodeGen/CodeGenAction.cpp       |    3 ++-
>  3 files changed, 12 insertions(+), 6 deletions(-)
>
> Re-posting the updated patch as I lost track of the original thread, and
> CC'ing in llvm-commits.
>
> You mentioned there's a remaining inconsistent ARM DataLayout that needs to
> get fixed before we switch this on -- was it determined if it's the LLVM or
> clang string that's at fault?

Not so much at fault. The issue is that llvm uses only the triple,
where clangs uses an attribute for the abi. I will ping that patch and
CC you.

Sorry for disappearing. I am spending the holidays with my parents, so
reading just a bit of email.

Cheers,
Rafael



More information about the cfe-commits mailing list