[PATCH] Fix crash in CFGReachabilityAnalysis triggered by IdempotentOperationChecker.

Alexander Kornienko alexfh at google.com
Wed Dec 18 02:47:06 PST 2013


  Changed the check to an assertion.

Hi krememek,

http://llvm-reviews.chandlerc.com/D2427

CHANGE SINCE LAST DIFF
  http://llvm-reviews.chandlerc.com/D2427?vs=6148&id=6162#toc

Files:
  lib/Analysis/CFGReachabilityAnalysis.cpp

Index: lib/Analysis/CFGReachabilityAnalysis.cpp
===================================================================
--- lib/Analysis/CFGReachabilityAnalysis.cpp
+++ lib/Analysis/CFGReachabilityAnalysis.cpp
@@ -23,7 +23,9 @@
   : analyzed(cfg.getNumBlockIDs(), false) {}
 
 bool CFGReverseBlockReachabilityAnalysis::isReachable(const CFGBlock *Src,
-                                          const CFGBlock *Dst) {
+                                                      const CFGBlock *Dst) {
+  // Blocks must be from the same CFG.
+  assert(Src->getParent() == Dst->getParent());
 
   const unsigned DstBlockID = Dst->getBlockID();
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2427.2.patch
Type: text/x-patch
Size: 637 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131218/c71d6b6b/attachment.bin>


More information about the cfe-commits mailing list