[PATCH] [ms-cxxabi] The "most derived" ctor parameter comes last

Timur Iskhodzhanov timurrrr at google.com
Tue Dec 17 02:47:34 PST 2013


  LGTM,

  Please add the following assertion:


================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:690
@@ -690,3 +689,3 @@
   ASTContext &Context = getContext();
   const CXXMethodDecl *MD = cast<CXXMethodDecl>(CGF.CurGD.getDecl());
   if (isa<CXXConstructorDecl>(MD) && MD->getParent()->getNumVBases()) {
----------------
  assert(isa<Constructor>(MD) || isa<Destructor>(MD));


http://llvm-reviews.chandlerc.com/D2405

BRANCH
  fix-most-derived

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list