[PATCH] [ms-cxxabi] Don't do destructor check on declarations if the dtor is deleted

Reid Kleckner rnk at google.com
Mon Dec 16 18:08:03 PST 2013


  LGTM as an intermediate step, but as discussed we should probably delay to vtable checking time or ODR using time or whatever that's called.


================
Comment at: lib/Sema/SemaDeclCXX.cpp:4475
@@ +4474,3 @@
+      // The Microsoft ABI requires that we perform the destructor body
+      // checks (i.e. operator delete() lookup) at every declaration, as
+      // any translation unit may need to emit a deleting destructor.
----------------
I'd drop "at every declaration" and say "in any translation unit..."


http://llvm-reviews.chandlerc.com/D2421



More information about the cfe-commits mailing list