[PATCH] Allow regexes in all verifier directives: drop the expected-(error|warning|note)-re, variants

Hans Wennborg hans at chromium.org
Thu Dec 12 11:22:16 PST 2013

On Thu, Dec 12, 2013 at 9:57 AM, Alp Toker <alp at nuanti.com> wrote:
> On 12/12/2013 17:28, Hans Wennborg wrote:
>> They're not that common
> 56 match-anything .* expressions have been landed to ToT and it hasn't even
> been a full day yet. This is clearly not a great plan.
> Match anything means just that -- match and silently ignore any regressions
> introduced in type handling or whatever appears in its place.

I think that's orthogonal to the question of what syntax to use for the regex.

Maybe we did over-relax the tests and should check more explicitly for
an optional calling convention attribute. Or maybe suppress them in
the TypePrinter. I believe there's a different thread for that
discussion though :)

> The {{}} syntax just makes it harder to grep and find these cases and have a
> clear idea of which tests are fuzzy matches now.

Grepping for "expect.*\.\*" works for finding these ones.

Requiring -re on directives with regexes makes them easier to grep
for, but I don't know how important that is.

 - Hans

More information about the cfe-commits mailing list