r196664 - Delete the now unnecessary test/generic-lambda-unimplemented-1y.cpp

Faisalv faisalv at gmail.com
Sat Dec 7 19:04:14 PST 2013


Hmm - i didnt realize it was crashing - ill revert the patches if i cant figure it out by tomorrow (if that's ok) - i did have second thoughts about adding that assertion ...

Sent from my iPhone

On Dec 7, 2013, at 8:31 PM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:

> This test was crashing when you delete it:
> 
> : Assertion `((IndexOfCaptureReadyLambda != (FunctionScopes.size() -
> 1)) || (S.getCurGenericLambda() &&
> S.getCurGenericLambda()->ImpCaptureStyle !=
> sema::LambdaScopeInfo::ImpCap_None)) && "The capture ready lambda for
> a potential capture can only be the " "current lambda if it is a
> generic lambda with an implicit capture"' failed.
> 
> We should fix that and at least keep the test to show it doesn't crash.
> 
> Also, the crash was introduced by r196662. Maybe it would be better to
> revert both commits for now?
> 
> 
> On 7 December 2013 15:57, Faisal Vali <faisalv at yahoo.com> wrote:
>> Author: faisalv
>> Date: Sat Dec  7 14:57:51 2013
>> New Revision: 196664
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=196664&view=rev
>> Log:
>> Delete the now unnecessary test/generic-lambda-unimplemented-1y.cpp
>> 
>> 
>> Removed:
>>    cfe/trunk/test/CXX/expr/expr.prim/expr.prim.lambda/generic-lambda-unimplemented-1y.cpp
>> 
>> Removed: cfe/trunk/test/CXX/expr/expr.prim/expr.prim.lambda/generic-lambda-unimplemented-1y.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CXX/expr/expr.prim/expr.prim.lambda/generic-lambda-unimplemented-1y.cpp?rev=196663&view=auto
>> ==============================================================================
>> --- cfe/trunk/test/CXX/expr/expr.prim/expr.prim.lambda/generic-lambda-unimplemented-1y.cpp (original)
>> +++ cfe/trunk/test/CXX/expr/expr.prim/expr.prim.lambda/generic-lambda-unimplemented-1y.cpp (removed)
>> @@ -1,31 +0,0 @@
>> -// RUN: %clang_cc1 -fsyntax-only -std=c++1y %s -verify
>> -//expected-no-diagnostics
>> -namespace lambda_capturing {
>> -// FIXME: Once return type deduction is implemented for generic lambdas
>> -// this will need to be updated.
>> -void test() {
>> -  int i = 10;
>> -  {
>> -    auto L = [=](auto a) -> int {
>> -      return i + a;
>> -    };
>> -    L(3);
>> -  }
>> -  {
>> -    auto L = [i](auto a) -> int {
>> -      return i + a;
>> -    };
>> -    L(3);
>> -  }
>> -  {
>> -    auto L = [i=i](auto a) -> int {
>> -      return i + a;
>> -    };
>> -    L(3);
>> -  }
>> -
>> -
>> -}
>> -
>> -}
>> -
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list