r196372 - do not warn about unknown pragmas in modes that do not handle them (pr9537)

Lubos Lunak l.lunak at centrum.cz
Wed Dec 4 06:11:39 PST 2013


On Wednesday 04 of December 2013, NAKAMURA Takumi wrote:
> I have reverted this. It triggered crashes on check-clang with +Asserts.
>
> http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/11922

 It seems unknown pragmas in STDC namespace are handled specially. Ok to push 
the patch again with the attached addition? All tests now pass even with 
assertions enabled here.

> 2013/12/4 Joerg Sonnenberger <joerg at britannica.bec.de>:
> > On Wed, Dec 04, 2013 at 10:21:41AM -0000, Lubos Lunak wrote:
> >> Author: llunak
> >> Date: Wed Dec  4 04:21:41 2013
> >> New Revision: 196372
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=196372&view=rev
> >> Log:
> >> do not warn about unknown pragmas in modes that do not handle them
> >> (pr9537)
> >>
> >> And refactor to have just one place in code that sets up the empty
> >> pragma handlers.
> >
> > Test case?

 ... Subversion ... It actually is in the patch, I'll remember to svn add it.

> > Otherwise, thanks for looking at this. Bill -- is it harmless 
> > enough to include in 3.4?

-- 
 Lubos Lunak
-------------- next part --------------
A non-text attachment was scrubbed...
Name: a.patch
Type: text/x-diff
Size: 984 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131204/8471011f/attachment.patch>


More information about the cfe-commits mailing list