[PATCH] [ms-cxxabi] Construct and destroy call arguments in the correct order

Richard Smith richard at metafoo.co.uk
Tue Dec 3 15:59:24 PST 2013


  LGTM


================
Comment at: lib/CodeGen/CGCall.cpp:1460-1464
@@ +1459,7 @@
+  if (getTarget().getCXXABI().areArgsDestroyedLeftToRightInCallee()) {
+    for (int i = Args.size() - 1; i >= 0; --i)
+      EmitParmDecl(*Args[i], ArgVals[i], i + 1);
+  } else {
+    for (unsigned i = 0, e = Args.size(); i != e; ++i)
+      EmitParmDecl(*Args[i], ArgVals[i], i + 1);
+  }
----------------
Capitalize `i` and `e`.


http://llvm-reviews.chandlerc.com/D2275

BRANCH
  arg-order-reverse

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list