[PATCH] clang-format VS plugin: bake clang-format.exe into the plug-in to make it self-contained

[Alp Toker]

On 02/12/2013 17:17, Hans Wennborg wrote:
>
> ================
> Comment at: tools/clang-format-vs/README.txt:9-10
> @@ +8,3 @@
> +
> +clang-format.exe must be copied into the ClangFormat/ directory before building.
> +It will be bundled into the .vsix file.
> ----------------
> Manuel Klimek wrote:
>> I assume the build fails now if we don't do this?
> Yes.
>
> ================
> Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:132
> @@ -130,1 +131,3 @@
>           {
> +            string vsixPath = Path.GetDirectoryName(Uri.UnescapeDataString(
> +                new UriBuilder(Assembly.GetExecutingAssembly().CodeBase).Path));
> ----------------
> Manuel Klimek wrote:
>> Is that the  same as AppDomain.CurrentDomain.BaseDirectory?
> No, that resolves to "C:\Program Files (x86)\Microsoft Visual Studio 11.0\Common7\IDE\" for me, whereas the plugin is actually buried inside "c:\Users\hans\AppData\Local\Microsoft\VisualStudio\11.0\extension\blah\"

There are some remarks that going through Uri doesn't escape well. How 
about something like this (untested) to directly get the path of the 
assembly defining ClangFormatPackage?

|string fullPath = Path.GetDirectoryName( 
typeof(ClangFormatPackage).Assembly.Location );|

Alp.


>
>
> http://llvm-reviews.chandlerc.com/D2281
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-- 
http://www.nuanti.com
the browser experts