[PATCH][AArch64] Two intrinsics are expected to return float64 not return float32.

Hao Liu Hao.Liu at arm.com
Thu Nov 28 19:02:19 PST 2013


Committed in 

http://llvm.org/viewvc/llvm-project?view=revision&revision=195943

 

Thanks,

-Hao

From: cfe-commits-bounces at cs.uiuc.edu
[mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Hao Liu
Sent: Friday, November 29, 2013 10:30 AM
To: cfe-commits at cs.uiuc.edu
Subject: [PATCH][AArch64] Two intrinsics are expected to return float64 not
return float32.

 

Hi,

 

This patch fixes a minor problem about arm_neon.h. 2 ALCE intrinsics have
incorrect return type.

For example in arm_neon.td, we define vcvt_f64:

def VCVT_F64 : SInst<"vcvt_f64", "fd",  "QlQUl">;

But in arm_neon.h, we get following incorrect intrinsics:

__ai float32x4_t vcvtq_f64_s64(int64x2_t __a) {

                  return
(float32x4_t)__builtin_neon_vcvtq_f64_v((int8x16_t)__a, 35); }

__ai float32x4_t vcvtq_f64_u64(uint64x2_t __a) {

                  return
(float32x4_t)__builtin_neon_vcvtq_f64_v((int8x16_t)__a, 51); }

The return type should be flaot64x2_t.

 

There are already many tests about such intrinsics. I don't add any tests.

 

As this is only a minor bug and I think it needs no code review, I'll commit
the patch firstly. 

If someone has comment about this, please tell me.

 

Thanks,

-Hao

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131129/1946da93/attachment.html>


More information about the cfe-commits mailing list