[PATCH] clang-format VS plugin: bake clang-format.exe into the plug-in to make it self-contained

Manuel Klimek klimek at google.com
Thu Nov 28 02:19:12 PST 2013



================
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:132
@@ -130,1 +131,3 @@
         {
+            string vsixPath = Path.GetDirectoryName(Uri.UnescapeDataString(
+                new UriBuilder(Assembly.GetExecutingAssembly().CodeBase).Path));
----------------
Is that the  same as AppDomain.CurrentDomain.BaseDirectory?

================
Comment at: tools/clang-format-vs/README.txt:9-10
@@ +8,3 @@
+
+clang-format.exe must be copied into the ClangFormat/ directory before building.
+It will be bundled into the .vsix file.
----------------
I assume the build fails now if we don't do this?


http://llvm-reviews.chandlerc.com/D2281



More information about the cfe-commits mailing list