[patch][pr17918] Use simple section names for COMDAT sections

Anton Korobeynikov anton at korobeynikov.info
Wed Nov 27 00:00:26 PST 2013


I'm worried about the changed semantics of .tls* sections.

I do not remember offhand why we emitted stuff into ".tls$LLVM", but
it was for a reason and you should make sure you have not broke it.
Full mingw32 bootstrap is not enough for this.

On Wed, Nov 27, 2013 at 3:23 AM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
> sorry, just the wrong list.
>
> On 26 November 2013 18:14, Richard Smith <richard at metafoo.co.uk> wrote:
>> On Tue, Nov 26, 2013 at 2:57 PM, Rafael EspĂ­ndola
>> <rafael.espindola at gmail.com> wrote:
>>>
>>> With the attached patch we use simple names for COMDAT sections (like
>>> .text or .bss). This matches the MSVC behavior.
>>>
>>> When merging it is the COMDAT symbol that is used to decide if two
>>> sections should be merged, so there is no point in building a fancy
>>> name.
>>>
>>> This survived a bootstrap on mingw32.
>>
>>
>> What sort of response are you looking for here? This isn't the right list
>> for a review, and the patch seems not ready for commit; do you want people
>> to test this on other platforms?
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University




More information about the cfe-commits mailing list