[PATCH] Fixing some ObjC attributes

Aaron Ballman aaron at aaronballman.com
Sun Nov 24 12:41:27 PST 2013


Thanks!  I've commit in r195578

~Aaron

On Fri, Nov 22, 2013 at 7:33 PM, jahanian <fjahanian at apple.com> wrote:
> LGTM.
> - Fariborz
>
> On Nov 22, 2013, at 1:19 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
>
>> In my quest for consolidated attribute subject diagnostics, I ran into
>> these two cases where we were handling ObjC attributes outside of the
>> norm. Specifically:
>>
>> objc_arc_weak_reference_unavailable had a Subjects that specified it
>> required an ObjcInterface, but no subject check in SemaDeclAttr.cpp
>> and no test case. This patch adds the semantics test and testcase.
>>
>> objc_requires_property_definitions had a Subjects that specified it
>> required an ObjCInterface, but the diagnostic issued from
>> SemaDeclAttr.cpp was a custom one instead of the common one. This
>> patch changes the diagnostic and corrects an existing testcase.
>>
>> Thanks!
>>
>> ~Aaron
>> <ObjCAttr.patch>
>



More information about the cfe-commits mailing list