r195047 - Make test/Driver/clang_f_opts.c not write to the test dir

Chad Rosier mcrosier at codeaurora.org
Tue Nov 19 11:06:07 PST 2013


Hi Hans,
IIRC, the general convention is to use %t for temporary files.  lit will
clean up after itself.  However, since your not running FileCheck on the
output maybe it doesn't matter.

  Chad

> Author: hans
> Date: Mon Nov 18 15:58:33 2013
> New Revision: 195047
>
> URL: http://llvm.org/viewvc/llvm-project?rev=195047&view=rev
> Log:
> Make test/Driver/clang_f_opts.c not write to the test dir
>
> After r195009, the test would write a .o file to the test dir. Send that
> to
> /dev/null instead. Also fix the typo in test/Frontend/invalid-o-level.c.
>
> Modified:
>     cfe/trunk/test/Driver/clang_f_opts.c
>     cfe/trunk/test/Frontend/invalid-o-level.c
>
> Modified: cfe/trunk/test/Driver/clang_f_opts.c
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/clang_f_opts.c?rev=195047&r1=195046&r2=195047&view=diff
> ==============================================================================
> --- cfe/trunk/test/Driver/clang_f_opts.c (original)
> +++ cfe/trunk/test/Driver/clang_f_opts.c Mon Nov 18 15:58:33 2013
> @@ -110,7 +110,7 @@
>  // CHECK-MAX-O: warning: -O4 is equivalent to -O3
>  // CHECK-MAX-O: -O3
>
> -// RUN: %clang -S -O20 %s 2>&1 | FileCheck -check-prefix=CHECK-INVALID-O
> %s
> +// RUN: %clang -S -O20 -o /dev/null %s 2>&1 | FileCheck
> -check-prefix=CHECK-INVALID-O %s
>  // CHECK-INVALID-O: warning: optimization level '-O20' is unsupported;
> using '-O3' instead.
>
>  // Test that we don't error on these.
>
> Modified: cfe/trunk/test/Frontend/invalid-o-level.c
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Frontend/invalid-o-level.c?rev=195047&r1=195046&r2=195047&view=diff
> ==============================================================================
> --- cfe/trunk/test/Frontend/invalid-o-level.c (original)
> +++ cfe/trunk/test/Frontend/invalid-o-level.c Mon Nov 18 15:58:33 2013
> @@ -1,4 +1,4 @@
> -// RUN: %clang_cc1 %s -O900 -o /dev/nul 2> %t.log
> +// RUN: %clang_cc1 %s -O900 -o /dev/null 2> %t.log
>  // RUN: FileCheck %s -input-file=%t.log
>
>  // CHECK: warning: optimization level '-O900' is unsupported; using '-O3'
> instead.
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation




More information about the cfe-commits mailing list