r194969 - Remove a bad string compare from r194968

Kim Gräsman kim.grasman at gmail.com
Mon Nov 18 00:59:14 PST 2013


On Mon, Nov 18, 2013 at 9:47 AM, Chandler Carruth <chandlerc at google.com> wrote:
> On Mon, Nov 18, 2013 at 12:34 AM, Kim Gräsman <kim.grasman at gmail.com> wrote:
>>
>> On Mon, Nov 18, 2013 at 9:23 AM, Chandler Carruth <chandlerc at google.com>
>> wrote:
>> >
>> > On Mon, Nov 18, 2013 at 12:20 AM, Manuel Klimek <klimek at google.com>
>> > wrote:
>> >>
>> >> Wouldn't the right fix have been to s/"/'/g?
>> >
>> > Yes.
>>
>> Actually no; it was comparing against "-c", not "c":
>>
>>    assert(*(End - 1) == "-c");
>
> Wow that "-" is small... ;]
>
> The point remains -- should probably be discussed rather than just removed.

I know, I missed it the first three or four passes over :-)

- Kim




More information about the cfe-commits mailing list