Update comment in FileManager.cpp

Yaron Keren yaron.keren at gmail.com
Thu Nov 14 05:55:06 PST 2013


It seems that the FIXME is already fixed:

NamedFileEnt = SeenFileEntries.GetOrCreateValue(Filename);
UFE.Name is const char* = InterndFileName  = NamedFileEnt.getKeyData();

so eventually UFE.Name does point to the key of SeenFileEntries.

In the remaining comment we're adding a file, not a directory.

Yaron
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131114/8287f2cc/attachment.html>
-------------- next part --------------
Index: lib/Basic/FileManager.cpp
===================================================================
--- lib/Basic/FileManager.cpp	(revision 194436)
+++ lib/Basic/FileManager.cpp	(working copy)
@@ -339,9 +339,7 @@
     return &UFE;
   }
 
-  // Otherwise, we don't have this directory yet, add it.
-  // FIXME: Change the name to be a char* that points back to the
-  // 'SeenFileEntries' key.
+  // Otherwise, we don't have this file yet, add it.
   UFE.Name    = InterndFileName;
   UFE.Size = Data.Size;
   UFE.ModTime = Data.ModTime;


More information about the cfe-commits mailing list