[PATCH] Improve the unwind.h inclusion

Richard Smith richard at metafoo.co.uk
Tue Nov 12 11:50:21 PST 2013


On Tue, Nov 12, 2013 at 10:23 AM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> On 12 November 2013 13:18, Sylvestre Ledru <sylvestre at debian.org> wrote:
> >
> >   I haven't dig enough in this to answer to your question about unwind.h
> itself.
> >
> >   It is just that I needed this patch when building with the package
> installed (I used to hardcode the path to the clang library).
> >   I think that applying this patch might save some time to the other
> packagers (but it might no longer be relevant).
>
> The question about unwind.h being complete was just a curiosity, but a
> just built clang looking at /usr/include/clang/3.4/include seems like
> a real bug that this might just hide.
>

Right, as I mentioned elsewhere, Debian's local patch to force
/usr/include/clang/3.4/include into the include path is incorrect. I don't
think we should take patches upstream to work around your local issues. I
would suggest that you pick a different solution to your packaging issue --
perhaps look for that directory via a compiler-relative path, not an
absolute one, as we do for ../lib/clang/3.4/include. (Or, failing that,
apply this patch to your local sources, and be aware that there may be more
pain in your future...)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131112/b135f9fc/attachment.html>


More information about the cfe-commits mailing list