[PATCH] Make clang-format editor integration files part of install target

Hans Wennborg hans at chromium.org
Tue Nov 12 11:16:18 PST 2013


Hi djasper, rnk,

I wanted to use clang-format in vim on Windows the other day, and noticed that clang-format.py wasn't shipped in the install, so I figured we should fix that.

A few questions:

1. Where to put this. First thought was to put them in bin/. But that doesn't make sense for the .el and .applescript files. So maybe we should just put the editor integration files under tools/

2. Should clang-format.py be renamed clang-format-vim.py to make its purpose more clear and be consistent with clang-format-sublime.py?

http://llvm-reviews.chandlerc.com/D2154

Files:
  tools/clang-format/CMakeLists.txt

Index: tools/clang-format/CMakeLists.txt
===================================================================
--- tools/clang-format/CMakeLists.txt
+++ tools/clang-format/CMakeLists.txt
@@ -13,4 +13,9 @@
   )
 
 install(TARGETS clang-format RUNTIME DESTINATION bin)
+install(PROGRAMS clang-format-bbedit.applescript DESTINATION tools)
+install(PROGRAMS clang-format-diff.py DESTINATION tools)
+install(PROGRAMS clang-format-sublime.py DESTINATION tools)
+install(PROGRAMS clang-format.el DESTINATION tools)
+install(PROGRAMS clang-format.py DESTINATION tools)
 install(PROGRAMS git-clang-format DESTINATION bin)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2154.1.patch
Type: text/x-patch
Size: 611 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131112/2ab0b009/attachment.bin>


More information about the cfe-commits mailing list