[PATCH] Make RewriteBuffer write in chunks

[Manuel Klimek]

 raw_ostream &RewriteBuffer::write(raw_ostream &os) const {
-  // FIXME: eliminate the copy by writing out each chunk at a time
-  os << std::string(begin(), end());
+  for (RopePieceBTreeIterator I = begin(), E = end(); I != E;
+       I.MoveToNextPiece())
+    os << I.piece();
   return os;

Why's it not ok to write ++I? (if there is a good reason, a comment might
help...)




On Fri, Nov 8, 2013 at 1:41 AM, Alp Toker <alp at nuanti.com> wrote:

> Updated patch to use StringRef instead of RopePieceBTreeIterator internals.
>
> Check it out
>
> Alp.
>
>
> On 07/11/2013 07:08, Alp Toker wrote:
> > Rewrite was previously allocating potentially huge std::strings with
> > each call and filling it one character at a time.
> >
> > This has become a hot path for Refactoring, Modernize, FixIt, Format,
> > and particularly ARCMT/ObjCMT which call it multiple times on the full
> > source tree -- so copying out contiguous chunks while avoiding large
> > allocations is a good idea.
> >
> > This commit preserves the existing interface of RewriteRope and pokes
> > into it directly for access to the byte vectors.
> >
> > Resolves a FIXME back from r101521. No change in behaviour.
> >
>
> --
> http://www.nuanti.com
> the browser experts
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131108/d2479a54/attachment.html>