[PATCH] Introduce clang-query tool.

Sean Silva silvas at purdue.edu
Wed Nov 6 12:51:58 PST 2013



================
Comment at: clang-query/Query.h:60-61
@@ +59,4 @@
+
+  static bool classof(const Query *Q) { return Q->Kind == QK_Invalid; }
+  static bool classof(const InvalidQuery *Q) { return true; }
+};
----------------
These `return true` classof's should be here. See <http://llvm.org/docs/HowToSetUpLLVMStyleRTTI.html>. In particular, see the second rule of thumb <http://llvm.org/docs/HowToSetUpLLVMStyleRTTI.html#rules-of-thumb>.


http://llvm-reviews.chandlerc.com/D2098

BRANCH
  clangquery

ARCANIST PROJECT
  clang-tools-extra



More information about the cfe-commits mailing list