[PATCH] extra libclang functionality for the xdress project

Geoffrey Irving irving at naml.us
Wed Nov 6 09:13:45 PST 2013


Thanks for the response!

On Wed, Nov 6, 2013 at 7:39 AM, Alp Toker <alp at nuanti.com> wrote:
>
> On 06/11/2013 14:55, Anthony Scopatz wrote:
>> Hello All,
>>
>> Could we please hear some response on this?  Thanks!
>
> Hello Anthony, Geoffrey,
>
> Thanks for the contribution.
>
> You'll need to rebase this work against current SVN, add at least a
> couple of standard lit tests and probably split it up into two or three
> bite-size chunks for review.

These are already rebased against current SVN.  What chucks should I
split it into?  It's already in four separate patches, of which three
are tiny and one is hard to divide since it exposes a new class of
objects.

> Once that's done, it can also help to CC in others who've recently
> worked on the C API in order to get buy-in.

Thanks!  I'll make some test cases once the build problem is resolved.

> As for Geoffrey's build problem, it's best to ask that as a separate
> question, including details about the platform and configuration if
> you're still struggling.

New thread coming up.

Geoffrey



More information about the cfe-commits mailing list