[PATCH] Replaced bool parameters in SkipUntil function with single bit-based parameter.

David Majnemer david.majnemer at gmail.com
Wed Nov 6 02:10:31 PST 2013

  From my experience,
  `SkipUntil(EndKind, /*StopAtSemi=*/true, /*DontConsume=*/true);`
  is more typical in clang than
  `SkipUntil(EndKind, StopAtSemi | DontConsume);`

  It seems that some of the calls that you changed were previously nasty (i.e. `SkipUntil(EndKind, true, true)`) which justifies a cleanup.
  However I'm not sure we want a bitfield here.

  What is your justification?

Comment at: include/clang/Parse/Parser.h:751
@@ -741,3 +750,3 @@
   /// token will ever occur, this skips to the next token, or to some likely
-  /// good stopping point.  If StopAtSemi is true, skipping will stop at a ';'
-  /// character.
+  /// good stopping point.  If Flags has bit set at StopAtSemi, skipping will
+  /// stop at a ';' character.
The wording "has bit set" seems strange.


More information about the cfe-commits mailing list