[clang-tools-extra] r194079 - [extra] pp-trace - Fixed problems found while writing docs.

[David Blaikie]

On Tue, Nov 5, 2013 at 10:59 AM, Thompson, John <
John_Thompson at playstation.sony.com> wrote:

>  More tests are coming.  I’m doing it incrementally, in groups of related
> callbacks.
>

It's really helpful to commit the tests along with the code change that
caused the test to pass - this means that when someone looks at why the
code was written the way it was, they can see the justification immediately
in the revision history.

It's not always possible, certainly, but a strong preference where
practical.

- David


>
>
> *From:* cfe-commits-bounces at cs.uiuc.edu [mailto:
> cfe-commits-bounces at cs.uiuc.edu] *On Behalf Of *David Blaikie
> *Sent:* Tuesday, November 05, 2013 8:19 AM
> *To:* John Thompson
> *Cc:* llvm cfe
> *Subject:* Re: [clang-tools-extra] r194079 - [extra] pp-trace - Fixed
> problems found while writing docs.
>
>
>
> Is there missing test coverage for these cases?
>
>
>
> On Tue, Nov 5, 2013 at 6:16 AM, John Thompson <
> John.Thompson.JTSoftware at gmail.com> wrote:
>
> Author: jtsoftware
> Date: Tue Nov  5 08:16:11 2013
> New Revision: 194079
>
> URL: http://llvm.org/viewvc/llvm-project?rev=194079&view=rev
> Log:
> [extra] pp-trace - Fixed problems found while writing docs.
>
> Modified:
>     clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp
>     clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h
>
> Modified: clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp?rev=194079&r1=194078&r2=194079&view=diff
>
> ==============================================================================
> --- clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp (original)
> +++ clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp Tue Nov  5
> 08:16:11 2013
> @@ -166,7 +166,7 @@ void PPCallbacksTracker::Ident(clang::So
>                                 const std::string &Str) {
>    beginCallback("Ident");
>    appendArgument("Loc", Loc);
> -  appendArgument("Path", Str);
> +  appendQuotedArgument("Str", Str);
>  }
>
>  // Callback invoked when start reading any pragma directive.
> @@ -175,7 +175,7 @@ PPCallbacksTracker::PragmaDirective(clan
>                                      clang::PragmaIntroducerKind
> Introducer) {
>    beginCallback("PragmaDirective");
>    appendArgument("Loc", Loc);
> -  appendArgument("Path", Introducer, PragmaIntroducerKindStrings);
> +  appendArgument("Introducer", Introducer, PragmaIntroducerKindStrings);
>  }
>
>  // Callback invoked when a #pragma comment directive is read.
>
> Modified: clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h
> URL:
> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h?rev=194079&r1=194078&r2=194079&view=diff
>
> ==============================================================================
> --- clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h (original)
> +++ clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h Tue Nov  5
> 08:16:11 2013
> @@ -160,9 +160,6 @@ public:
>    /// \brief Append a string to the top trace item.
>    void append(const char *Str);
>
> -  /// \brief Format and append a string to the top trace item.
> -  void appendFormatted(const char *Format, ...);
> -
>    /// \brief Append a bool argument to the top trace item.
>    void appendArgument(const char *Name, bool Value);
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131105/09a9ef52/attachment.html>