[PATCH] CodeGen: Minor cleanup/simplification in CGStmt

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Nov 4 07:16:52 PST 2013

I like the test, but the comment should probably be "Test that simple
expressions are simplified at -O0", no? :-)

On 3 November 2013 22:22, Justin Bogner <mail at justinbogner.com> wrote:
> Rafael EspĂ­ndola <rafael.espindola at gmail.com> writes:
>>> That seems like a good idea, but I need some input on where such a test
>>> would go and how to structure it. I don't really see any similar tests.
>>> From what I can see, EmitBranchOnBoolExpr is basically doing some
>>> trivial constant folding so that our codegen at -O0 is reasonable.
>> If you can get a C testcase it should probably go in clang/test/CodeGen.
> What do you think of something like this? I'm not entirely convinced
> this is a very good test, but it's hard to write "avoid extraneous basic
> blocks" in test form. The best I could think of was avoiding unnecessary
> phis.
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

More information about the cfe-commits mailing list