[PATCH] Microsoft improperly sized array fields

Warren Hunt whunt at google.com
Fri Nov 1 16:52:12 PDT 2013

Comment at: lib/AST/ASTContext.cpp:1391
@@ +1390,3 @@
+  if (!Context.getTargetInfo().getCXXABI().isMicrosoft() ||
+      Context.getTargetInfo().getPointerWidth(0) == 64)
+    Width = llvm::RoundUpToAlignment(Width, Align);
David Majnemer wrote:
> Should this check be grafted into a new method off of the CXXABI class? Might be useful if we find out 64-bit ARM is different.
Might be.  At present I vote we cross the ARM bridge when we get there.  I'm uncomfortable asserting anything about how ARM behaves without testing it first.  If ARM32 and X86 have notable similarities and ARM64 and X64 have notable similarities then I think it warrants coming up with some abstractions for them.


More information about the cfe-commits mailing list