Re: [PATCH] Implement aarch64 neon instructio​n class SIMD Bitwise Extract - LLVM

Tim Northover t.p.northover at gmail.com
Fri Nov 1 04:04:44 PDT 2013


  Hi Jiangning,

  Just one small refactor that needs to happen here. Mostly it looks fine to me.

  Cheers

  Tim


================
Comment at: lib/Target/AArch64/AArch64InstrNEON.td:3953
@@ +3952,3 @@
+  let ParserMatchClass = uimm3_asmoperand;
+  let PrintMethod = "printNeonUImm8Operand";
+}
----------------
OK, this function seriously needs renaming now. I don't know why I didn't notice before.


http://llvm-reviews.chandlerc.com/D2073



More information about the cfe-commits mailing list