r193815 - Clang modules: collect exports recursively

Richard Smith richard at metafoo.co.uk
Thu Oct 31 18:47:26 PDT 2013

I had a go at writing a test for this (attached). However... my test fails
both with and without your change.

On Thu, Oct 31, 2013 at 6:22 PM, Richard Smith <richard at metafoo.co.uk>wrote:

> On Thu, Oct 31, 2013 at 5:39 PM, Dmitri Gribenko <gribozavr at gmail.com>wrote:
>> On Thu, Oct 31, 2013 at 5:33 PM, Richard Smith <richard at metafoo.co.uk>
>> wrote:
>> > Please add a testcase!
>> Sorry, I don't think this is feasible -- the testcase will involve a
>> mock of this whole huge module structure.  Offline Doug OK'ed
>> committing this without a testcase.
> Could you test this by adding relevant (empty) modules to
> test/Modules/Inputs/module.map and maybe one extra header?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131031/da824b35/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: r193815-test.diff
Type: text/x-patch
Size: 1867 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131031/da824b35/attachment.bin>

More information about the cfe-commits mailing list