Add -fauto-profile option to Clang driver
chandlerc at google.com
Wed Oct 30 11:38:52 PDT 2013
LGTM (with a comment in phab for you).
One note I forgot to mention there: can you put the input file (foo.prof or
whatever) in the Inputs subdirectory of test/Driver?
On Wed, Oct 30, 2013 at 11:09 AM, Diego Novillo <dnovillo at google.com> wrote:
> On Mon, Oct 28, 2013 at 2:13 PM, Justin Bogner <mail at justinbogner.com>
> > Bob Wilson <bob.wilson at apple.com> writes:
> >> On Oct 28, 2013, at 7:23 AM, Diego Novillo <dnovillo at google.com> wrote:
> >>> Ping? Bob, Chandler, does this sound reasonable to you? I'm thinking
> >>> of changing the current patch to use -fprofile-sample-use=...
> >>> This partially keeps the symmetry with -fprofile-generate /
> >>> -fprofile-use and avoids the autodetection logic that Chandler
> >>> dislikes.
> >> I don't have a strong opinion on this. Justin, how does this line up
> >> with what you were considering for our profiling options?
> > Using -fprofile-sample-use= seems simplest for now. We'll probably need
> > to figure out exactly what to do with -fprofile-use= and
> > -fprofile-generate= in the near future, as the current state is actually
> > fairly strange:
> > - profile-use and profile-use= are ignored
> > - profile-generate= isn't accepted
> > - profile-generate causes libprofile_rt to be linked in, but does
> > nothing else
> > In GCC, -fprofile-generate implies -fprofile-arcs, which we currently
> > use to turn on the GCOVProfilerPass, and the =path versions of these
> > options take a directory, whereas both Diego's and Bob's profiling
> > approaches deal with a file.
> I've renamed the flag and moved the patch over to phabricator:
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits