[PATCH] Make thunk this/return adjustment ABI-specific. Also, fix the return adjustment when using -cxx-abi microsoft

Timur Iskhodzhanov timurrrr at google.com
Wed Oct 30 04:59:53 PDT 2013



================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1014
@@ +1013,3 @@
+    int32_t IntSize =
+        getContext().getTypeSizeInChars(getContext().IntTy).getQuantity();
+    llvm::Value *VBPtr;
----------------
Reid Kleckner wrote:
> I'm frustrated that I can't think of a shorter way to write this.
Could as well be just "4" :)

================
Comment at: include/clang/Basic/ABI.h:51
@@ +50,3 @@
+      int64_t VBaseOffsetOffset;
+    };
+
----------------
unnamed structs in a union turned out to be MSVC+gcc extensions, so I've named them


http://llvm-reviews.chandlerc.com/D2026



More information about the cfe-commits mailing list