r193665 - Minor efficiency refactor related to 193661. No functional change.

Warren Hunt whunt at google.com
Tue Oct 29 17:14:55 PDT 2013


Author: whunt
Date: Tue Oct 29 19:14:55 2013
New Revision: 193665

URL: http://llvm.org/viewvc/llvm-project?rev=193665&view=rev
Log:
Minor efficiency refactor related to 193661.  No functional change.

Modified:
    cfe/trunk/lib/CodeGen/CGRecordLayoutBuilder.cpp

Modified: cfe/trunk/lib/CodeGen/CGRecordLayoutBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGRecordLayoutBuilder.cpp?rev=193665&r1=193664&r2=193665&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGRecordLayoutBuilder.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGRecordLayoutBuilder.cpp Tue Oct 29 19:14:55 2013
@@ -201,11 +201,9 @@ public:
 }
 
 void CGRecordLayoutBuilder::Layout(const RecordDecl *D) {
-  Alignment = Types.getContext().getASTRecordLayout(D).getAlignment();
-  Packed = D->hasAttr<PackedAttr>();
   const ASTRecordLayout &Layout = Types.getContext().getASTRecordLayout(D);
-  if (Layout.getSize() % Layout.getAlignment() != 0)
-    Packed = true;
+  Alignment = Layout.getAlignment();
+  Packed = D->hasAttr<PackedAttr>() || Layout.getSize() % Alignment != 0;
 
   if (D->isUnion()) {
     LayoutUnion(D);





More information about the cfe-commits mailing list