[PATCH] [StaticAnalyzer] New checker StringPlusChar

Jordan Rose jordan_rose at apple.com
Fri Oct 25 09:55:34 PDT 2013


This looks great. Committed as r193418, with two tiny changes: instead of hardcoding the host system's UCHAR_MAX, I used llvm::isUIntN with the char width in the AST context. In practice this will almost always be the same, of course. The other change is that I merged note_string_plus_int_silence and note_string_plus_char_silence into a single note_string_plus_scalar_silence, because they're the currently same. We can always change that later.

Thanks, Anders!
Jordan


On Oct 24, 2013, at 23:27 , Anders Rönnholm <Anders.Ronnholm at evidente.se> wrote:

> Hi,
> 
> New iteration where char16_t is taken care of.
> 
> //Anders





More information about the cfe-commits mailing list