[PATCH] [libcxx] Use better prefix for macro indicating a shared DLL build

Reid Kleckner rnk at google.com
Thu Oct 24 14:01:41 PDT 2013


Cool, please commit.


On Thu, Oct 24, 2013 at 1:48 PM, Nico Rieck <nico.rieck at gmail.com> wrote:

> On 24.10.2013 19:46, Reid Kleckner wrote:
>
>> Should this be behind the LIBCXX_ENABLE_SHARED conditional?
>>
>
> CMake docs state that DEFINE_SYMBOL defines the symbol when compiling a
> shared library. I just tested that this is indeed the case, so there's no
> need to make it conditional.
>
> -Nico
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131024/9e1ba845/attachment.html>


More information about the cfe-commits mailing list