[PATCH] AArch32 target support

Bernie Ogden bogden at arm.com
Thu Oct 24 11:37:16 PDT 2013


Commits r193364-7.

Regards,

Bernie

> -----Original Message-----
> From: Bernie Ogden [mailto:bogden at arm.com]
> Sent: 18 October 2013 13:13
> To: David Tweed; James Molloy; cfe-commits at cs.uiuc.edu
> Subject: RE: [PATCH] AArch32 target support
> 
> D'oh - couldn't see for looking. I've fixed that locally.
> 
> As I've now addressed all of James' comments, I'll commit on Monday
> unless someone wants to stop me on the basis of the two questions I
> asked in my previous mail.
> 
> Regards,
> 
> Bernie
> 
> > -----Original Message-----
> > From: David Tweed
> > Sent: 18 October 2013 10:39
> > To: Bernard Ogden; James Molloy; cfe-commits at cs.uiuc.edu
> > Subject: RE: [PATCH] AArch32 target support
> >
> > Hi Bernie,
> >
> > * I don't see the coding style violation - what am I missing?
> >
> > I think James is just referring to not placing the else on the same
> > line as
> > the previous closing brace in
> >
> > >      }
> > > +    else if (CPU == "cortex-a53" || CPU == "cortex-a57") {
> >
> > Cheers,
> > Dave
> >








More information about the cfe-commits mailing list