[PATCH] Use GEPs correctly when adjusting "this" in MicrosoftCXXABI

Timur Iskhodzhanov timurrrr at google.com
Wed Oct 23 07:13:31 PDT 2013


2013/10/23 Chandler Carruth <chandlerc at google.com>:
>
> On Fri, Oct 18, 2013 at 8:46 AM, Timur Iskhodzhanov <timurrrr at google.com>
> wrote:
>>
>> I'll fix the GEP UB in the thunk emission code as part of my next vtordisp
>> patch.
>
>
> FYI, I would love to see more incremental patches here. If you have a bugfix
> to code you're already working on a new feature in, I think it is often a
> worthwhile tradeoff to fix the bug, and then merge that fix into your
> existing work. Not sure if that's the case here, just wanted to mention it
> from the peanut gallery.

Sorry for the confusion, I did mean to land the next fix as a standalone
patch, just want to change the code a bit more before I can send this
out for review.



More information about the cfe-commits mailing list