[PATCH] Move SUMMARY: prefix to ReportErrorSummary

Kostya Serebryany kcc at google.com
Wed Oct 23 00:44:07 PDT 2013


LGTM


On Wed, Oct 23, 2013 at 11:30 AM, Nick Lewycky <nlewycky at google.com> wrote:

> Hi kcc,
>
> http://llvm-reviews.chandlerc.com/D2004
>
> Files:
>   lib/sanitizer_common/sanitizer_common.cc
>
> Index: lib/sanitizer_common/sanitizer_common.cc
> ===================================================================
> --- lib/sanitizer_common/sanitizer_common.cc
> +++ lib/sanitizer_common/sanitizer_common.cc
> @@ -168,7 +168,8 @@
>    const int kMaxSize = 1024;  // We don't want a summary too long.
>    InternalScopedBuffer<char> buff(kMaxSize);
>    internal_snprintf(
> -      buff.data(), kMaxSize, "%s: %s %s:%d %s", SanitizerToolName,
> error_type,
> +      buff.data(), kMaxSize, "SUMMARY: %s: %s %s:%d %s",
> SanitizerToolName,
> +      error_type,
>        file ? StripPathPrefix(file, common_flags()->strip_path_prefix) :
> "??",
>        line, function ? function : "??");
>    __sanitizer_report_error_summary(buff.data());
> @@ -233,6 +234,6 @@
>  }
>
>  void __sanitizer_report_error_summary(const char *error_summary) {
> -  Printf("SUMMARY: %s\n", error_summary);
> +  Printf("%s\n", error_summary);
>  }
>  }  // extern "C"
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131023/ff3a64be/attachment.html>


More information about the cfe-commits mailing list