r193073 - Fix to PR8880 (clang dies processing a for loop).

Chandler Carruth chandlerc at google.com
Tue Oct 22 11:00:03 PDT 2013

On Tue, Oct 22, 2013 at 10:33 AM, Serge Pavlov <sepavloff at gmail.com> wrote:

> This problem has been fixed in r193170.
> I regret about troubles. GCC rejects very similar syntax and without a
> proper test it was very simple to break software that uses this strange
> feature.
> I believe the fix is useful and change in r193170 will be enough to pacify
> QT world.

You never answered who reviewed this. I plan to back all of this out until
you get pre-commit review.

You also didn't put the QT test case back. You should. We actually have
customers relying on Clang supporting QT which is why we had test cases for
it. Please don't remove test cases that you don't understand.

Please start a review thread for your fix to this PR rather than committing
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131022/e57dcb24/attachment.html>

More information about the cfe-commits mailing list