[PATCH] Fix crash in cleanup attr handling

Alp Toker alp at nuanti.com
Sun Oct 20 11:53:49 PDT 2013


Thanks, landed in r193055 with an additional comment documenting
ResolveSingleFunctionTemplateSpecialization() behaviour.

Alp.

On 20/10/2013 15:42, Aaron Ballman wrote:
> Patch LGTM!
>
> ~Aaron
>
> On Sun, Oct 20, 2013 at 2:19 AM, Alp Toker <alp at nuanti.com> wrote:
>> Reduction:
>>
>> void c3(int *a) {
>>   void c3() {}
>>   void t3() {
>>     int v1 __attribute__((cleanup(c3)));
>> }
>>
>> ResolveSingleFunctionTemplateSpecialization() returns 0 and doesn't emit
>> diags unless the expression has template-ids, so we must null check the
>> result.
>>
>> Also add a better diag noting which overloads are causing the problem.
>>
>> --
>> http://www.nuanti.com
>> the browser experts
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>

-- 
http://www.nuanti.com
the browser experts




More information about the cfe-commits mailing list