[PATCH] Make InstantiatingTemplate depth checks clearer

Alp Toker alp at nuanti.com
Thu Oct 17 12:42:13 PDT 2013


For the record this landed in r192177.

On 07/10/2013 21:21, Richard Smith wrote:
> On Sun, Oct 6, 2013 at 8:01 AM, Alp Toker <alp at nuanti.com
> <mailto:alp at nuanti.com>> wrote:
>
>     This one was caught by the RAII class style checker I mentioned on
>     llvm-commits to improve code readability:
>
>         The bool conversion operator on InstantiatingTemplate never added
>     value and
>         only served to obfuscate the template instantiation routines.
>
>         This patch replaces the conversion and its callers with an
>     explicit
>     isInvalid()
>         function to make it clear what's going on at a glance.
>
>     OK to commit?
>
>
> Yes, LGTM

-- 
http://www.nuanti.com
the browser experts




More information about the cfe-commits mailing list