[PATCH] clang-cl: add support for /FA (output assembly file)

Reid Kleckner rnk at google.com
Tue Oct 15 17:21:26 PDT 2013

  LGTM with a fix to make /Fa not require /FA.

Comment at: include/clang/Driver/CLCompatOptions.td:118
@@ +117,3 @@
+def _SLASH_Fa : CLJoined<"Fa">,
+  HelpText<"Set filename to use for /FA">,
+  MetaVarName<"<file or directory>">;
I always use /Fa only, which implies /FA, so I'd make the doc text here stand on its own without referencing /FA.

Comment at: test/Driver/cl-outputs.c:106
@@ +105,2 @@
+// RUN: %clang_cl /Fafoo -### -- %s 2>&1 | FileCheck -check-prefix=FaNOFA %s
+// FaNOFA: argument unused during compilation: '/Fafoo'
This should output asm to foo.asm, I think.


More information about the cfe-commits mailing list