[patch] Emit aliases for more constructors (V2)

David Blaikie dblaikie at gmail.com
Fri Oct 11 14:27:44 PDT 2013


On Fri, Oct 11, 2013 at 2:17 PM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> After spending some time figuring out what the actual restrictions ELF
> puts on alias I think this new patch is correct.
>
> What the previous one was getting wrong is that sometimes it would
> output just the base destructor. If we are using aliases and
> implementing weak functions with comdats, we have to make sure every
> translation unit emits comdats with the same symbols. If we don't, the
> linker can decide to keep a copy that has only the base destructor and
> the link gets an undefined reference to the complete destructor.
>
> I have tested the patch by using a patched clang to build a debug
> version of clang.
>

Since you've got it setup, have you run this against the GDB 7.5 test suite?


>
> Cheers,
> Rafael
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131011/13584fa4/attachment.html>


More information about the cfe-commits mailing list