[PATCH] clang-modernize: Add SubprocessCompilationDatabase

[Edwin Vane]

I'm not sure if this is a step toward tools acting as CXX replacements but
I renamed the class to something a little more describe of what it does as
opposed to what it's used for.


On Fri, Oct 11, 2013 at 3:13 AM, Kim Gräsman <kim.grasman at gmail.com> wrote:

> Hi Edwin,
>
> On Fri, Oct 11, 2013 at 12:34 AM, Edwin Vane <edwin.vane at intel.com> wrote:
> >
> >   The problem is the FixedCompilationDatabase mangles the arguments you
> pass. FixedCompilationDatabase as a result has some preconditions: the name
> of the compiler should not be present nor should be the filename to operate
> on. Check CompilationDatabase.h for a better description. As stated in the
> patch summary we need a simpler compilation database that simply accepts a
> full list of args and then provides those same args back upon request.
>
> This sounds nice, but the name feels a little funny... Isn't it just a
> LiteralCompilationDatabase? The subprocess forwarding is just one use
> case, unless I'm missing something. I'm still interested in allowing
> tools to act as CXX replacements in build systems, for example, and it
> feels like this is as step on the way there?
>
> - K
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



-- 
Edwin V
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131011/f73bb940/attachment.html>