[PATCH] [ms-cxxabi] Remove hack from GetAddrOfCXXDestructor for complete dtors

Timur Iskhodzhanov timurrrr at google.com
Thu Oct 10 09:27:20 PDT 2013


I think supporting destructor aliases for classes that have just one
destructor is a wrong thing to do.

Please take a look at my alternative patch?

2013/10/9 Reid Kleckner <rnk at google.com>:
> Hi timurrrr,
>
> Now that -mconstructor-aliases works for linkonce functions, we should
> use aliases instead.  This makes our code less consistent with MSVC's
> code, but that was never really a goal.
>
> http://llvm-reviews.chandlerc.com/D1872
>
> Files:
>   lib/CodeGen/CGCXX.cpp
>   test/CodeGenCXX/microsoft-abi-exceptions.cpp
>   test/CodeGenCXX/microsoft-abi-sret-and-byval.cpp
>   test/CodeGenCXX/microsoft-abi-static-initializers.cpp
>   test/CodeGenCXX/microsoft-abi-structors.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dtors_alternative.patch
Type: application/octet-stream
Size: 3868 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131010/01a60ce4/attachment.obj>


More information about the cfe-commits mailing list