[PATCH] Initialize vtorDisp in class constructors and destructors

Timur Iskhodzhanov timurrrr at google.com
Wed Oct 9 07:48:04 PDT 2013


Hi rnk,

This is not a full vtorDisp support (e.g. vtorDisp thunks are still TODO), but an important step forward.

If vtorDisp is not initialized (as is as of ToT), executing a vtorDisp thunk (e.g. emitted by CL) is very likely to cause segfault, even on a completely-constructed object. With this patch, we can at least correctly handle completely-constructed objects.

Other pieces of the puzzle will follow.

http://llvm-reviews.chandlerc.com/D1867

Files:
  lib/CodeGen/CGCXXABI.h
  lib/CodeGen/CGClass.cpp
  lib/CodeGen/MicrosoftCXXABI.cpp
  test/CodeGenCXX/microsoft-abi-virtual-inheritance.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1867.1.patch
Type: text/x-patch
Size: 9202 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131009/16b6a47d/attachment.bin>


More information about the cfe-commits mailing list