[patch] [libcxx] cmakelists.txt patch to disable int to bool error warning for msvc

G M gmisocpp at gmail.com
Wed Oct 9 07:30:11 PDT 2013


Hi Everyone

Here's a patch to disable implicit int to bool warnings for msvc libcxx by
changing the project file default to silence this warning.

There are about a dozen or so instances of this warning in libcxx and I am
happy to make those changes manually if consensus forms to prefer that but
so far that isn't the case.

It's simply changing things like bool b = x & m; to b = (x&m) != 0;

In absence of consensus to me making these types of changes I've gone with
this change to the project file to disable the warnings instead. This
change only effects MSVC, other compilers already default to this it seems.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131010/28aa43a7/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmakelists.txt.diff
Type: application/octet-stream
Size: 692 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131010/28aa43a7/attachment.obj>


More information about the cfe-commits mailing list