[patch] [libcxx] deque the intended version!

Marshall Clow mclow.lists at gmail.com
Tue Oct 8 21:47:26 PDT 2013


On Oct 8, 2013, at 6:18 PM, G M <gmisocpp at gmail.com> wrote:

> Hi Marshall
>  
> When I look at my patch (the one that doesn't include the kitchen sink) on my machine it refers to this routine:
>  
> // line 1438:
> 
> +#if _LIBCPP_STD_VER > 11 // added by me.
> 
> template <class _Tp, class _Allocator>
> 
> deque<_Tp, _Allocator>::deque(size_type __n, const _Allocator& __a)
> 
> : __base(__a)
> 
> {
> 
> if (__n > 0)
> 
> __append(__n);
> 
> }
> +#endif // added by me because otherwise there's no matching declaration.
>  
> For which the explicit constructor has the same #if _LIBCPP_STD_VER > 11
>  
> // The constructor is on line 1213 in my file.
> 
> #if _LIBCPP_STD_VER > 11
> 
> explicit deque(size_type __n, const _Allocator& __a);
> 
> #endif 
> 
In the copy I have here, 
$ svn info deque
	Path: deque
	Name: deque
	Working Copy Root Path: /Sources/LLVM/libcxx2
	URL: https://marshall@llvm.org/svn/llvm-project/libcxx/trunk/include/deque
	Repository Root: https://marshall@llvm.org/svn/llvm-project
	Repository UUID: 91177308-0d34-0410-b5e6-96231b3b80d8
	Revision: 192273
	Node Kind: file
	Schedule: normal
	Last Changed Author: hhinnant
	Last Changed Rev: 191987
	Last Changed Date: 2013-10-04 15:09:00 -0700 (Fri, 04 Oct 2013)
	Text Last Updated: 2013-10-08 21:38:24 -0700 (Tue, 08 Oct 2013)
	Checksum: 4eb3e2c9b5af6d8173795125cf6f91e84cfcc556

That  routine is already wrapped in a "#if _LIBCPP_STD_VER > 11" block, which was added (along with the routine) in revision 190251.
So I am quite confused.

-- Marshall

Marshall Clow     Idio Software   <mailto:mclow.lists at gmail.com>

A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait).
        -- Yu Suzuki

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131008/3c6255a8/attachment.html>


More information about the cfe-commits mailing list