[PATCH] Abstract out parts of thunk emission code, add support for simple thunks for -cxx-abi microsoft

Reid Kleckner rnk at google.com
Tue Oct 8 11:10:57 PDT 2013


  LGTM

  Let's see what breaks once this is fixed.  :)


================
Comment at: lib/AST/VTableBuilder.cpp:2255
@@ +2254,3 @@
+struct VTableThunksComparator {
+  bool operator()(const VTableLayout::VTableThunkTy &LHS,
+                  const VTableLayout::VTableThunkTy &RHS) {
----------------
Just use a function for this, no need for a class.

================
Comment at: lib/AST/VTableBuilder.cpp:2958
@@ -2931,1 +2957,3 @@
 
+struct MicrosoftThunkInfoStableSortComparator {
+  bool operator() (const ThunkInfo &LHS, const ThunkInfo &RHS) {
----------------
Ditto, plain function.


http://llvm-reviews.chandlerc.com/D1787



More information about the cfe-commits mailing list