[PATCH] [WIP] clang-format: Enforce EOL at EOF as required by C standard

Daniel Jasper djasper at google.com
Tue Oct 8 09:00:03 PDT 2013


On Sun, Oct 6, 2013 at 10:50 PM, Alp Toker <alp at nuanti.com> wrote:

>
> On 06/10/2013 21:10, Alp Toker wrote:
> >> I am sorry that you regard the response as negative.. I probably just
> >> don't understand some of your reasoning and am thus leaning towards
> >> solving this in a slightly different fashion.
> > I see where you're coming from but it doesn't quite work for solving the
> > tooling problems AFAICT.
> >
> > So, I think this topic is worth re-visiting some weeks down the line
> > once we've had a chance to digest the matter.
> >
> In the meantime, here's a standalone fix for the exit code mentioned in
> the original patch.
>
> I'm not sure how to write a portable test for this, any idea where to look?
>

No, not really. I guess we could try to check in or create a readonly file.
clang-format should then fail as it cannot write the formatted file, but I
am doubtful that this is portable.

Submitted the patch as is in r192184.


>
> --
> http://www.nuanti.com
> the browser experts
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131008/fc5e41e4/attachment.html>


More information about the cfe-commits mailing list