[PATCH] [ms-cxxabi] Fix the calling convention for operator new in records

Reid Kleckner rnk at google.com
Mon Oct 7 16:52:49 PDT 2013



================
Comment at: include/clang/Sema/DeclSpec.h:2084
@@ +2083,3 @@
+    return getContext() == MemberContext &&
+           getDeclSpec().getStorageClassSpec() != DeclSpec::SCS_typedef &&
+           !getDeclSpec().isFriendSpecified();
----------------
Richard Smith wrote:
> A typedef declaration is a member.
OK, I don't need that.  I can special case typedefs in SemaType.

================
Comment at: include/clang/Sema/DeclSpec.h:2083
@@ +2082,3 @@
+  bool isMember() {
+    return getContext() == MemberContext &&
+           getDeclSpec().getStorageClassSpec() != DeclSpec::SCS_typedef &&
----------------
Richard Smith wrote:
> If we have a nested name specifier that names a class, then we are declaring a record member.
Changed to isFirstDeclarationOfMember as discussed.


http://llvm-reviews.chandlerc.com/D1761



More information about the cfe-commits mailing list