[PATCH] [StaticAnalyzer] New checker StringPlusChar

[Daniel Marjamäki]

Hello!

Thank you for the rapid response.

> I think the check makes some sense. If I have

Yes I agree.

> The idea and the patch both seem good to me, other than the diagnostic wording. Perhaps something like:

Yes your suggestion sounds good.

> I wonder whether we want to catch more than just DeclRefExprs on the pointer side.

Yes.

However in the first patch I'd prefer if we only catch plain pointers. I hope this is ok for you.

There are a few improvements we can make in this checking later.. when the first patch is accepted.

Best regards,
Daniel Marjamäki

..................................................................................................................
Daniel Marjamäki Senior Engineer
Evidente ES East AB  Warfvinges väg 34  SE-112 51 Stockholm  Sweden

Mobile:                 +46 (0)709 12 42 62
E-mail:                 Daniel.Marjamaki at evidente.se

www.evidente.se